Revert "revert" to test toolchain change #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 3, 2021
Contributor
|
Tracking testing this alongside Swift here: swiftlang/swift#40031 |
Contributor
Author
|
The test on Swift repo seems to be success. Could you please run test on this so that we can merge it if it success? @franklinsch |
Contributor
|
Now that the smoke tests pass, I also triggered toolchain builds in that PR. @swift-ci please test |
Contributor
Author
Seems like both smoke tests and toolchain builds are passed. Could you review the change and merge it? @franklinsch |
Contributor
Author
|
@franklinsch Could we run test again and merge it? |
Contributor
|
@swift-ci Please test |
Contributor
|
@swift-ci Please test |
QuietMisdreavus
approved these changes
Nov 10, 2021
Contributor
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
It looks like the Swift toolchains built just fine with this PR, so let's go ahead and (re-)land it!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
Revert #11 and #12 to test the change in the toolchain build.
@franklinsch
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded